godaddy / godaddy/kubernetes-client

An in-range update of mustache is breaking the build 🚨

Open
#534 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

greenkeeper
Dominant language
JavaScript
Stars
962
Forks
189
No merged PRs in 30d

Description

The devDependency mustache was updated from 3.0.1 to 3.0.2.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

mustache is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • ❌ continuous-integration/travis-ci/push: The Travis CI build failed (Details).
Release Notes for v3.0.2
Fixed
Dev
  • #701: Fix test failure for Node 10 and above, by @andersk.
  • #704: Lint all test files just like the source files, by @phillipj.
  • Start experimenting & comparing GitHub Actions vs Travis CI, by @phillipj.
Commits

The new version differs by 15 commits.

  • 6c3608b :ship: bump to version 3.0.2
  • 619c928 Delete old GitHub Actions workflow file
  • fc8eb5d Convert to new GitHub Actions yaml format
  • 1c4187a Don't run browser tests on IE 9 and IE 10, start from IE 11 and above
  • 69e2bf3 Add mustache partials indentation spec and fix one broken test
  • cadf571 Indent Partials
  • 1a244cb Install deps before tests in Actions workflow
  • 930a485 Install deps as part of GitHub Actions workflow
  • d0290c4 Try a basic GitHub Actions workflow
  • bb700c5 Start linting all test/ files as part of test script (#704)
  • 11ac71a Run tests on Node.js 10 & 12 after CLI test got fixed
  • 932ad33 cli-test: fs.unlink → fs.unlinkSync to fix test failure on Node 10 (#701)
  • 78eb820 Run tests on Node.js 8 as well
  • fe06a16 Cut official support for Node.js 0.8 by not running tests on it anymore (#700)
  • 639c94f Updated Beard Competition URL in README.md (#699)

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Greenkeeper failing branch and the linked Travis CI build to identify the failed check after mustache changed from 3.0.1 to 3.0.2. Inspect the dependency and build configuration that the failing check uses; done means the project build passes with the intended mustache version.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
build-system, ci-cd
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.