godaddy / godaddy/datastar

Delete `map` keys

Open
#12 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
41
Forks
9
PR merge metrics
No merged PRs in 30d

Description

Either `#update()` needs to support deleting map keys (maybe triggered by `null` values?), or `#remove()` semantics need to be updated to support deleting map keys.

Since we already have validation that `#update()` cannot set map keys to `null`, I propose that `null` values in here will generate a `DELETE [""] FROM WHERE ` statement.

Right now, to "delete" a map key, we are required to set it to some sort of empty value. This is fine for most maps, but causes problems with a `map`.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.