godaddy-wordpress / godaddy-wordpress/wc-plugin-framework

Generate PHP i18n files in framework

Open
#806 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
PHP
Stars
146
Forks
43
Avg merge
21m
Merged PRs (30d)
3

Description

We received [this report](https://wordpress.org/support/topic/braintree-for-woocommerce-not-using-new-wordpress-translation-architecture/) of slowness in the WooCommerce Braintree payment gateway due to the generated translation files still generating only PO and MO files, and not [the more performant PHP files](https://make.wordpress.org/core/2024/02/27/i18n-improvements-6-5-performant-translations/) that have been in WordPress core since 6.5.

I reviewed the existing GitHub workflow to update translation files in `.github/workflows/update-translations-files.yml`, but that only generates MO files using the code from the `gdcorp-partners/localization-actions`. I can't access that upstream repo to see if we could easily add PHP file generation (e.g. by shifting to a more recent version of that upstream code), or if we should aim to use a local script that calls `wp i18n make-php` from WP-CLI ([docs](https://developer.wordpress.org/cli/commands/i18n/make-php/)).

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.