godaddy-wordpress / godaddy-wordpress/go

Go Theme 1.8.11 through 1.8.18 inconsistent site-title tags and rendering

Open
#951 0 comments 0 reactions 0 assignees View on GitHub
[Type] Bug [Type] Design
Dominant language
PHP
Stars
338
Forks
69
PR merge metrics
No merged PRs in 30d

Description

In the “Go” theme since version 1.8.11, site-title includes an h1 tag only on the home [static] page, versus using span tags on all other pages.

Example of home page code:
`

Hannam BnB Seoul

`

Example of all other pages on site:
`Hannam BnB Seoul`

The result is that the site title doesn’t justify consistently from the home page to all other pages, and, while re-sizing pages in the web browser, the site title in the header does not conform to the new dimensions consistently from page to page.

It is my opinion that the way the site title “folds” on the home page with the h1 tag is more attractive than the way it folds on pages without the h1 tag, but that is only my opinion. See the website and experiment!

Tested in the latest versions of Chrome, Firefox and Edge on Win10pro (sorry) and latest WP versions. Reproducibility varies slightly with browser window width.

I’m assuming, correctly I hope, that this was unintentional and not by design? And I'm guessing I'm the only one with that long a title?

Thank you everyone for your hard work!

See live site at https://hannambnb.com to view issue.

This is the home page with the h1 tag:
Image

This is any other page using span:

Image

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.