godaddy-wordpress / godaddy-wordpress/coblocks
ISBAT transform Gallery blocks that have Gutter controls
- Dominant language
- JavaScript
- Stars
- 794
- Forks
- 142
- PR merge metrics
- No merged PRs in 30d
Description
### Describe the bug:
Custom Gutter controls have been introduced for use with CoBlocks gallery blocks. The changes can be found here: https://github.com/godaddy-wordpress/coblocks/pull/1619. The controls have only be implemented within a subset of CoBlocks Gallery blocks which is causing some quirks with transforms.
Legacy gutter controls and the newer gutter controls component linked in this issue have differing types of props. The schemas of these attributes cannot be easily transfigured which ultimately results in invalid attributes being defined for gallery blocks when transforming.
This issue should be resolved by
1. Correctly implementing the Gutter controls across all gallery blocks.
**Blocks that have new gutter controls**
[ ] Masonry
[ ] Stacked
[x] Offset
[x] Collage
[ ] Carousel
2. Re-enable gallery transforms for gutter props.
* Changes to re-enable can be found here: https://github.com/godaddy-wordpress/coblocks/pull/1718
### To reproduce:
1. Add gallery masonry
2. Add images and transform to Offset.
3. Save the page and reload to see the invalid block error.
### Expected behavior:
Expect transforms to properly transform attributes in a compatible way.
### Isolating the problem:
- [x] This bug happens with no other plugins activated
- [x] This bug happens with a default WordPress theme active
- [x] This bug happens **without** the Gutenberg plugin active
- [x] I can reproduce this bug consistently using the steps above
### WordPress version:
5.5.1
### Gutenberg version:
N/A
Contributor guide
Assessment
This issue has not been assessed yet.