gocodebox / gocodebox/lifterlms

Allow Block-level visibility for account edit forms

Open
#3,255 0 comments 0 reactions 1 assignee Claimed by @brianhogg View on GitHub
hacktoberfest Type: Enhancement Type: Feature Request
Dominant language
PHP
Stars
212
Forks
140
Avg merge
2d 14h
Merged PRs (30d)
19

Description

Related: https://github.com/gocodebox/lifterlms-blocks/issues/142

Currently, block level visibility is globally disabled for blocks in an account edit form.

This was added *intentionally*. Visibility is disabled for registration forms because *they're only ever displayed to logged out users* and as the inverse account edit forms are only shown to logged in users... However, given the scenario that a user creates a field (on checkout) that's only visible to users of Membership A and they want to display that field on the account edit form to users only enrolled in that membership, they cannot do this and the field is now shown to users regardless of their enrollment in membership A (on the account edit form).

However... there are fields on the account edit form that we should disable visibility for entirely:

Email, password, and display name should *always* be visible on the account edit form otherwise users cannot change essential account fields. Other fields can be conditionally visibile.

All fields that have visibility options enabled should have the "logged out" option removed since logged out users can't view the form it doesn't make sense to provide the option.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.