gocodebox / gocodebox/lifterlms
Editing notification text in editor overrides translations without a way to go back
- Dominant language
- PHP
- Stars
- 212
- Forks
- 140
- Avg merge
- 2d 14h
- Merged PRs (30d)
- 19
Description
### Reproduction Steps
* Set language to something else than English
* Notifications are now translated to your chosen language as long as you have existing translations
* Go to LifterLMS -> Settings -> Notifications
* Pick Basic or Email for any item in the list
* Edit Title or Body
* Save Changes
* Edit Title or Body again to revert your changes
* Save Changes
### Expected Behavior
When I revert to the original text, the system should realize that it should use what's found in loaded translation files. Alternatively, there should be a "reset" or "revert" button in the editor, which would make the system to respect translations again.
### Actual Behavior
As a result, your edits override whatever translation you had for the notification. If you go back and revert your edits, the notification still stays in English, and you can no longer use the translations provided in translation files.
### System and Environment Information
LifterLMS 8.0.1
This issue has be recreated:
+ [x] On a production website
### Browser, Device, and Operating System Information
+ Firefox
+ MacOS
Contributor guide
Assessment
This issue has not been assessed yet.