gocodebox / gocodebox/lifterlms

Small Yoast and LifterLMS notification conflict

Open
#1,779 2 comments 0 reactions 1 assignee Claimed by @actuallyakash View on GitHub
Severity: Low Status: Has Alternative Status: Has PR Type: Conflict
Dominant language
PHP
Stars
212
Forks
140
Avg merge
2d 14h
Merged PRs (30d)
19

Description

### Reproduction Steps

+ HS-175163
+ Install LifterLMS and Yoast
+ On a course add the LifterLMS login shortcode [lifterlms_login]
+ In an incognito window go to the course and enter dummy information for an account that doesn't exit

### Expected Behavior

+ The LifterLMS notice for "no account found with username/password combination" displays

### Actual Behavior

+ Yoast prevents the notice and it does not display (though this only seems to happen with courses if you add the shortcode on a normal page it's fine)

### Error Messages / Logs

+ Include any relevant error messages or log files
```

```

### System and Environment Information

System Report

```
Wordpress
-------------------------------------------

Home Url: https://natalie-5-testing.myliftersite.com
Site Url: https://natalie-5-testing.myliftersite.com
Login Url: https://natalie-5-testing.myliftersite.com/wp-login.php
Version: 5.8.1
Debug Mode: Yes
Debug Log: Yes
Debug Display: Yes
Locale: en_US
Multisite: No
Page For Posts: Not Set
Page On Front: Homepage (#950) [https://natalie-5-testing.myliftersite.com/]
Permalink Structure: /%postname%/
Show On Front: page
Wp Cron: Yes

Settings
-------------------------------------------

Version: 5.3.0
Db Version: 5.3.0
Course Catalog: Not Set
Membership Catalog: Not Set
Student Dashboard: Student Dashboard (#12) [https://natalie-5-testing.myliftersite.com/dashboard/]
Checkout Page: Purchase (#11) [https://natalie-5-testing.myliftersite.com/purchase/]
Course Catalog Per Page: -1
Course Catalog Sorting: menu_order,ASC
Membership Catalog Per Page: 9
Membership Catalog Sorting: menu_order,ASC
Site Membership: Not Set
Courses Endpoint: my-courses
Edit Endpoint: edit-account
Lost Password Endpoint: lost-password
Vouchers Endpoint: redeem-voucher
Autogenerate Username: yes
Password Strength Meter: yes
Minimum Password Strength: strong
Terms Required: yes
Terms Page:(#156) []
Checkout Names: required
Checkout Address: required
Checkout Phone: optional
Checkout Email Confirmation: yes
Open Registration: no
Registration Names: required
Registration Address: optional
Registration Phone: hidden
Registration Voucher: optional
Registration Email Confirmation: no
Account Names: required
Account Address: required
Account Phone: optional
Account Email Confirmation: yes
Confirmation Endpoint: confirm-payment
Force Ssl Checkout: no
Country: IE
Currency: USD
Currency Position: left
Thousand Separator: ,
Decimal Separator: .
Decimals: 2
Trim Zero Decimals: no
Recurring Payments: yes
Email From Address: team+sandbox@lifterlms.com
Email From Name: A LifterLMS Sandbox
Email Footer Text:
Email Header Image: 880
Cert Bg Width: 800
Cert Bg Height: 616
Cert Legacy Compat: no

Constants
-------------------------------------------

LLMS_REMOVE_ALL_DATA: undefined
LLMS_REST_DISABLE: undefined
LLMS_SITE_FEATURE_RECURRING_PAYMENTS: undefined
LLMS_SITE_IS_CLONE: undefined

Gateways
-------------------------------------------

Manual: Enabled
Manual Logging: no
Manual Order: 1

Server
-------------------------------------------

Mysql Version: 5.7.35
Php Curl: Yes
Php Default Timezone: UTC
Php Fsockopen: Yes
Php Max Input Vars: 5000
Php Max Upload Size: 512 MB
Php Memory Limit: 256M
Php Post Max Size: 1024M
Php Soap: Yes
Php Suhosin: No
Php Time Limt: 30
Php Version: 7.3.30
Software: Apache/2.4.48 (Unix) OpenSSL/1.1.1
Wp Memory Limit: 256M

Browser
-------------------------------------------

HTTP USER AGENT: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/93.0.4577.63 Safari/537.36

Theme
-------------------------------------------

Name: Astra
Version: 3.6.9
Themeuri: https://wpastra.com/
Authoruri: https://wpastra.com/about/
Template:
Child Theme: No
Llms Support: Yes

Plugins
-------------------------------------------

LifterLMS: 5.3.0
User Switching: 1.5.7
Yoast SEO: 17.1

Integrations
-------------------------------------------

BbPress: No
BuddyPress: No

Template Overrides
-------------------------------------------

```

This issue has be recreated:
+ [X] Locally
+ [X] On a staging site
+ [X] On a production website
+ [X] With only LifterLMS and a default theme

### Browser, Device, and Operating System Information

+ Browser name and version
+ Operating System name and version
+ Device name and version (if applicable)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.