gocodebox / gocodebox/lifterlms

Yoast conflict on prereq setting dropdown in lessons

Open
#1,159 0 comments 0 reactions 0 assignees View on GitHub
good first issue hacktoberfest help wanted Severity: Low Status: Has Alternative Type: Conflict
Dominant language
PHP
Stars
212
Forks
140
Avg merge
2d 14h
Merged PRs (30d)
19

Description

### Reproduction Steps

+ Turn on LifterLMS
+ Turn on Yoast
+ Go into edit a lesson
+ Go down to the settings for the lesson and open the prereq screen

### Expected Behavior

+ The dropdown will look like you would expect a dropdown select menu to look

### Actual Behavior

+ The dimensions of the dropdown are out of proportion, you can't see what you selected, and the view bar takes up 100% width of the settings box.

### System and Environment Information

System Report

```

Wordpress
-------------------------------------------

Home Url: [removed]
Site Url: [removed]
Login Url: [removed]/wp-login.php
Version: 5.4.1
Debug Mode: Yes
Debug Log: No
Debug Display: No
Locale: en_US
Multisite: No
Page For Posts: Not Set
Page On Front: Home (#2457) [[removed]/]
Permalink Structure: /%postname%/
Show On Front: page
Wp Cron: Yes

Settings
-------------------------------------------

Version: 3.38.2
Db Version: 3.38.2
Course Catalog: Course Catalog (#2406) [[removed]/pinker/]
Membership Catalog: Membership Catalog (#2407) [[removed]/memberships/]
Student Dashboard: Dashboard (#1491) [[removed]/dashboard/]
Checkout Page: Purchase (#1490) [[removed]/purchase/]
Course Catalog Per Page: -1
Course Catalog Sorting: menu_order,ASC
Membership Catalog Per Page: 9
Membership Catalog Sorting: menu_order
Site Membership: Not Set
Courses Endpoint: my-courses
Edit Endpoint: edit-account
Lost Password Endpoint: lost-password
Vouchers Endpoint: redeem-voucher
Autogenerate Username: yes
Password Strength Meter: yes
Minimum Password Strength: strong
Terms Required: no
Terms Page: Not Set
Checkout Names: required
Checkout Address: optional
Checkout Phone: hidden
Checkout Email Confirmation: no
Open Registration: no
Registration Names: required
Registration Address: hidden
Registration Phone: hidden
Registration Voucher: optional
Registration Email Confirmation: no
Account Names: required
Account Address: required
Account Phone: optional
Account Email Confirmation: yes
Confirmation Endpoint: confirm-payment
Force Ssl Checkout: no
Country: GB
Currency: USD
Currency Position: left
Thousand Separator: ,
Decimal Separator: .
Decimals: 2
Trim Zero Decimals: no
Recurring Payments: yes
Email From Address: [removed]
Email From Name: [removed]
Email Footer Text:
Email Header Image:
Cert Bg Width: 800
Cert Bg Height: 616
Cert Legacy Compat: no

Gateways
-------------------------------------------

Manual: Disabled
Manual Logging:
Manual Order: 1

Server
-------------------------------------------

Mysql Version: 5.7.25
Php Curl: Yes
Php Default Timezone: UTC
Php Fsockopen: Yes
Php Max Input Vars: 1000
Php Max Upload Size: 8 MB
Php Memory Limit: 256M
Php Post Max Size: 8M
Php Soap: Yes
Php Suhosin: No
Php Time Limt: 30
Php Version: 7.3.1
Software: Apache
Wp Memory Limit: 40M

Browser
-------------------------------------------

HTTP USER AGENT: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.138 Safari/537.36

Theme
-------------------------------------------

Name: LifterLMS LaunchPad
Version: 2.4.6
Themeuri: https://lifterlms.com/launchpad/
Authoruri: https://gocodebox.com
Template:
Child Theme: No
Llms Support: No

Plugins
-------------------------------------------

LifterLMS: 3.38.2
Yoast SEO: 14.1

Integrations
-------------------------------------------

BbPress: No
BuddyPress: No

Template Overrides
-------------------------------------------

```

This issue has be recreated:
+ [X] Locally
+ [X] On a staging site
+ [X] On a production website
+ [ ] With only LifterLMS and a default theme

HS-121577

+ Not that this is just a visual issue. The prereqs do actually save and function as normal, and can be set without issue from inside the builder as well.

Contributor guide

Open the contributing guide

Research direction

Reproduce the issue with LifterLMS 3.38.2 and Yoast SEO 14.1 by opening a lesson's prerequisite settings screen. Inspect the dropdown and its surrounding styles to identify the conflict; done means the control has normal dimensions and the selected value is visible while prerequisite saving continues to work.

Written by the indexing model from the issue text.

Assessment

Tech stack
php, wordpress
Domain
design, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.