gocodebox / gocodebox/lifterlms
Adding external URLs to Quiz descriptions escapes quotes [ACF plugin conflict]
- Dominant language
- PHP
- Stars
- 212
- Forks
- 140
- Avg merge
- 2d 14h
- Merged PRs (30d)
- 19
Description
### Reproduction Steps
When creating a quiz, add a link to the description section. Once saved, if you refresh the page and view the URL it escaped quotations. Example, if I put in this code
`
`After saving it appears like this:
`
`### Expected Behavior
I would expect the quotes for the link attributes would not be escaped.
### Actual Behavior
Quotes are escaped.
### Error Messages / Logs
+ Include any relevant error messages or log files
```
```
### System Information
System Report
```
Wordpress
-------------------------------------------
Home Url: https://traindemocrats.org
Site Url: https://traindemocrats.org
Login Url: https://traindemocrats.org/wp-login.php
Version: 5.3.2
Debug Mode: No
Debug Log: No
Debug Display: Yes
Locale: en_US
Multisite: No
Page For Posts: NDTC Blog (#186) [https://traindemocrats.org/blog/]
Page On Front: Home (#195) [https://traindemocrats.org/]
Permalink Structure: /%postname%/
Show On Front: page
Wp Cron: Yes
Settings
-------------------------------------------
Version: 3.37.9
Db Version: 3.37.9
Course Catalog: Course Catalog (#4437) [https://traindemocrats.org/course-catalog/]
Membership Catalog: Not Set
Student Dashboard: Dashboard (#164) [https://traindemocrats.org/dashboard/]
Checkout Page: Not Set
Course Catalog Per Page: -1
Course Catalog Sorting: menu_order,ASC
Membership Catalog Per Page: 9
Membership Catalog Sorting: menu_order
Site Membership: Not Set
Courses Endpoint: my-courses
Edit Endpoint: edit-account
Lost Password Endpoint: lost-password
Vouchers Endpoint:
Autogenerate Username: yes
Password Strength Meter: no
Minimum Password Strength: weak
Terms Required: no
Terms Page: Not Set
Checkout Names: optional
Checkout Address: optional
Checkout Phone: optional
Checkout Email Confirmation: no
Open Registration: yes
Registration Names: optional
Registration Address: optional
Registration Phone: hidden
Registration Voucher: hidden
Registration Email Confirmation: no
Account Names: optional
Account Address: optional
Account Phone: optional
Account Email Confirmation: no
Confirmation Endpoint: confirm-payment
Force Ssl Checkout: no
Country: US
Currency: USD
Currency Position: left
Thousand Separator: ,
Decimal Separator: .
Decimals: 2
Trim Zero Decimals: no
Recurring Payments: no
Email From Address: info@traindemocrats.org
Email From Name: NDTC
Email Footer Text:
Email Header Image:
Cert Bg Width: 800
Cert Bg Height: 616
Cert Legacy Compat: no
Gateways
-------------------------------------------
Manual: Disabled
Manual Logging: no
Manual Order: 1
Server
-------------------------------------------
Mysql Version: 5.7.28
Php Curl: Yes
Php Default Timezone: UTC
Php Fsockopen: Yes
Php Max Input Vars: 10000
Php Max Upload Size: 200 MB
Php Memory Limit: 512M
Php Post Max Size: 200M
Php Soap: Yes
Php Suhosin: No
Php Time Limt: 3600
Php Version: 7.3.14-6+ubuntu18.04.1+deb.sury.org+1
Software: Apache
Wp Memory Limit: 40M
Browser
-------------------------------------------
HTTP USER AGENT: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/79.0.3945.117 Safari/537.36
Theme
-------------------------------------------
Name: NDTC
Version: 9.0.9
Themeuri: https://traindemocrats.org
Authoruri: https://roots.io/
Template:
Child Theme: No
Llms Support: No
Plugins
-------------------------------------------
Admin Columns Pro: 5.0.0
Admin Columns Pro - Advanced Custom Fields (ACF): 2.5.5
Advanced Custom Fields PRO: 5.8.7
Advanced Forms Pro: 1.6.6
Akismet Anti-Spam: 4.1.3
Disable Gutenberg: 2.0
Disqus Conditional Load: 11.0.1
Email Marketing by Drip: 1.0.2
LifterLMS: 3.37.9
LifterLMS Advanced Quizzes: 1.0.10
LifterLMS Assignments: 1.1.4
LifterLMS Custom Fields: 1.0.2
LifterLMS Helper: 3.0.2
LifterLMS Private Areas: 1.1.1
LifterLMS Social Learning: 1.2.1
NDTC Cron Tasks:
Phone Number Field for Advanced Custom Fields: 1.0.0
SendGrid: 1.11.8
Super Socializer: 7.12.37
Wordfence Security: 7.4.6
WordPress Importer: 0.6.4
WP Crontrol: 1.7.1
Yoast SEO: 13.0
Integrations
-------------------------------------------
BbPress: No
BuddyPress: No
LifterLMS Private Areas: No
LifterLMS Social Learning: No
Template Overrides
-------------------------------------------
```
### Browser, Device, and Operating System Information
+ Browser name and version
Chrome Version 79.0.3945.117
+ Operating System name and version
MacOS Mojave 10.14.6 (18G95)
+ Device name and version (if applicable)
MacBook Pro (15-inch, 2019)
Contributor guide
Research direction
Reproduce the issue by adding an external link to a quiz description, saving it, and refreshing the page to compare the stored and displayed markup. Trace the LifterLMS quiz-description flow and its interaction with the reported Advanced Custom Fields conflict. Done means quoted link attributes remain valid after saving and existing description formatting still works.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php, wordpress
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100