Structs sets domain causes many incomparable comparisons on zstd
Nobody has claimed this yet.
- Dominant language
- OCaml
- Stars
- 252
- Forks
- 90
- Avg merge
- 4d 1m
- Merged PRs (30d)
- 19
Description
Out of curiosity I wanted to try the sets domain for base structs (from #419) on zstd, because with simple structs we lose the relationship between its thread pool functions and their arguments:
Therefore we end up calling all the job functions with all the opaque arguments, so calling the functions with arguments of completely wrong types, which cannot possibly be good for precision.
Unfortunately it generates an insane amount of incomparable warnings like:
warn_type leq: incomparable abstr. values Int and Address at lib/common/fse_decompress.c:267:14-267:54: (0) and {}
It's so bad that in a minute it produces more output than the entire ~45 minute analysis with simple structs on zstd.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the sets domain analysis on zstd and inspect the incomparable-value warning reported at lib/common/fse_decompress.c:267:14-267:54. Start by comparing this run with the simple-struct analysis; done means the excessive incomparable warnings are addressed without losing the intended relationship between thread-pool functions and their arguments.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c, ocaml
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100