goauthentik / goauthentik/authentik
Honor Password Stage failed-attempts limit on combined login
- Dominant language
- Python
- Stars
- 25.6k
- Forks
- 2k
- Avg merge
- 1d 1h
- Merged PRs (30d)
- 644
Description
## What
Password Stage “Failed attempts before cancel” is ignored when the password stage is embedded on the Identification stage (combined login). Also: “Failed attempts before cancel”: #21600 is a different symptom (limit works once, then is infinite) vs combined-login ignore. Same setting; confirm same counter.
## Want
- Password Stage “Failed attempts before cancel” is ignored when the password stage is embedded on the Identification stage (combined login)
- Related “Failed attempts before cancel”: #21600 is a different symptom (limit works once, then is infinite) vs combined-login ignore
- Confirm same counter
## Ideas this came from
- [#8685 Failed attempts before cancel not working when password stage set on identification stage](https://github.com/goauthentik/authentik/issues/8685) — When setting Password stage to default-authentication-password on the default-authentication-identification, the "Failed attempts before cancel" are not being a
- [#10196 Failed attempts is NOT working When Password stage is in Identification Stage](https://github.com/goauthentik/authentik/issues/10196) — using lasted version of Authentik in docker in Ubuntu in Oracle VPS When Password stage is added in Identification Stage instead of second stage then Failed att
- [#21600 Password Stage Failed Attempts Before Cancel Only Works once](https://github.com/goauthentik/authentik/issues/21600) — In my auth flow, I have "Failed attempts before cancel" set to 5 in my Password Stage. If I then fail the password 5 times, the flow successfully ends as expect
Contributor guide
Research direction
Start by reproducing the Password Stage “Failed attempts before cancel” behavior in separate and combined Password Stage/Identification Stage login flows. Compare the failed-attempt counter with the behavior described in #21600. Done means the configured limit is honored consistently in combined login and the counter behavior is confirmed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- authentication, security
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100