makeHot doesn't accept possible Store parameters
- Dominant language
- JavaScript
- Stars
- 3.4k
- Forks
- 312
- PR merge metrics
- No merged PRs in 30d
Description
I was trying to port code such as `this.store = alt.createStore(NoteStore, storeName, this.actions);` to use `makeHot`. Sadly it looks like `makeHot` doesn't allow parameters to be passed to Store. I expect that for this to work you would need to do something like:
``` javascript
function makeHot(alt, Store, name = Store.displayName, parameters) {
if (module.hot) {
module.hot.dispose(() => {
delete alt.stores[name]
})
}
return alt.createStore(Store, name, parameters)
}
export default makeHot
```
Maybe this was just a simple oversight? I can provide a PR if you want but given it's so trivial change, perhaps just add it there yourself it this makes sense to you.
Contributor guide
Assessment
This issue has not been assessed yet.