goatslacker / goatslacker/alt

browser builds of React with addons are broken

Open
#394 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
3.4k
Forks
312
PR merge metrics
No merged PRs in 30d

Description

996932d0423c9ca8f0b158065738b00e2a4cfeb1 breaks React with addons for System.js and the like.
The browser build of React with addons includes the addons in the same file, while in [the current config](https://github.com/goatslacker/alt/blob/996932d0423c9ca8f0b158065738b00e2a4cfeb1/dist.config.js#L22), it does a `require('react/addons')` which is incompatible.

Contributor guide

Open the contributing guide

Research direction

Start with dist.config.js at line 22 and compare it with commit 996932d0423c9ca8f0b158065738b00e2a4cfeb1. Inspect how the browser build includes React addons for System.js and similar environments. Reproduce the browser build and verify that the generated file keeps the addons bundled without the incompatible require('react/addons').

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react
Domain
build-system, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.