go-sql-driver / go-sql-driver/mysql

Expose MysqlParameterConverter as alternative to DefaultParameterConverter that lacks uint64 support

Open
#1,637 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
15.3k
Forks
2.3k
Avg merge
2h 23m
Merged PRs (30d)
10

Description

### Issue description
We are trying to use sql.Null[uint64]{}. While it works for mysql database the check fails for sqlMock, because it uses default converter that is not aware of uint64.

sqlMock uses DefaultParameterConverter and it fails with uint64.
https://github.com/DATA-DOG/go-sqlmock/blob/master/sqlmock.go#L112-L114

Now DefaultParameterConverter is public from go/sql package.
https://github.com/golang/go/blob/master/src/database/sql/driver/types.go#L213C2-L213C47

However sqlmock supports providing different parameter converter.
https://github.com/DATA-DOG/go-sqlmock/blob/master/options.go#L10-L15

Basically if you are willing to expose it as MysqlParameterConverter:
https://github.com/go-sql-driver/mysql/blob/master/statement.go#L135

### Example code
```go
db, sqlMock, err := sqlmock.New(sqlmock.ValueConverterOption(MysqlParameterConverter{}))
```

### Error log
```
sql: converting argument $7 type: non-Value type uint64 returned from Value
```

### Configuration
*Driver version (or git SHA):* 1.8.1

*Go version:* 1.23.2

*Server version:* MySQL 8.0, sqlmock 1.5.2

*Server OS:* MacOSX

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.