go-kit / go-kit/kit

support for istio distributed tracing

Open
#977 4 comments 0 reactions 0 assignees View on GitHub
enhancement help wanted
Dominant language
Go
Stars
27.4k
Forks
2.4k
PR merge metrics
No merged PRs in 30d

Description

Hi guys,

I've been using go-kit for some times now (high five for the amazing work !) and have been developing micro-services on Kubernetes and istio where istio tracing is leveraged. If interested in supporting istio tracing through simple header propagation ([istio doc](https://istio.io/faq/distributed-tracing/#how-to-support-tracing)), I have working code that I would be happy to push through a pull request.

Basically the code implements the function `func ServerBefore(before ...RequestFunc) ServerOption` for HTTP and gRPC

defined here
* https://github.com/go-kit/kit/blob/master/transport/http/server.go#L51
* https://github.com/go-kit/kit/blob/master/transport/grpc/server.go#L60

so that header values can be saved in the `context`, and then inject to every downstream requests.

Is it something you see being pushed to your code base ? Let me know.
Cheers

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.