go-kit / go-kit/kit

ErrSignatureInvalid from jwt-go lib should be handled by jwt parser

Open
#947 1 comment 0 reactions 0 assignees View on GitHub
help wanted
Dominant language
Go
Stars
27.4k
Forks
2.4k
PR merge metrics
No merged PRs in 30d

Description

I'm playing around with jwt errors handling and I found out that there is a [HS256-specific error](https://github.com/dgrijalva/jwt-go/blob/dc14462fd58732591c7fa58cc8496d6824316a82/hmac.go#L21) in jwt-go library that is returned as inner error by the go-kit parser. I believe that this error should be handled by the parser and `ErrTokenInvalid` should be returned.

Any thoughts?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.