go-kit / go-kit/kit

Please, add proper attribution to log/term/*

Open
#640 3 comments 0 reactions 0 assignees View on GitHub
enhancement help wanted
Dominant language
Go
Stars
27.4k
Forks
2.4k
PR merge metrics
No merged PRs in 30d

Description

Hi,

While preparing a Debian package for go-kit, the FTP masters rejected my package because of missing attribution in log/term/*

I checked the code and it seems it is deriving from ssh/terminal (although I don't see much code coming from there) and from github.com/mattn/go-colorable. There is a LICENSE file, which does not attribute properly either work, nor their original licenses (the Go license is BSD, not MIT), and attributes code to one Simon Eskildsen, who's not mentioned anywhere else.

All in all, copyright and licensing is very unclear in that directory. Could you please clarify it?

Thanks!

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.