go-kit / go-kit/kit

StdLibAdapter doesn't correctly recognize panics from net/http when running a http server

Open
#233 2 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Go
Stars
27.4k
Forks
2.4k
PR merge metrics
No merged PRs in 30d

Description

When running a http server using the stdlib's net/http (the idiomatic way to do this in Go) and when using `stdlog.SetOutput(log.NewStdlibAdapter(logger))`, any panics recovered from by net/http and then printed out will be mangled. Only the top line will be shown in the msg field. Additionally, the file field is wrong.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.