gnosis / gnosis/util-contracts

networks-inject reports success even if it couldn't inject addresse

Open
#32 1 comment 0 reactions 0 assignees View on GitHub
bug
Dominant language
Solidity
Stars
50
Forks
18
PR merge metrics
No merged PRs in 30d

Description

From [discord](https://discord.com/channels/477106835862716416/477390900830535680/727252704317145220)

> also I found a clear bug that if you make empty build/contracts and run yarn run networks-inject it will say that all is fine, but do nothing

If we cannot inject the addresses into the contracts we should fail the script and let the user know.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at the networks-inject entry point invoked by yarn and reproduce the issue with an empty build/contracts directory. Trace how unsuccessful address injection is handled. Done means the command reports failure and clearly tells the user when addresses could not be injected, rather than reporting success.

Written by the indexing model from the issue text.

Assessment

Tech stack
solidity
Domain
blockchain
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.