gnosis / gnosis/safe-cmm-app-react

Bug: start price is not cleared out when swap tokens

Open
#86 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
TypeScript
Stars
2
Forks
1
PR merge metrics
No merged PRs in 30d

Description

# Description
When I fill in the start price field with a value (f.e. with a market price) and then swap tokens, the previous price value remains to be displayed in the start price field

# To Reproduce:
1. Go to Deploy tab
2. Pick a Token A and a Token B
3. Click on the market price value --> the value appears n the Start Price field
4. Swap the Token A and the Token B

# Actual Behavior
Value in the Start Price field remain to be the same

# Expected Behavior
Start price value is not cleared out when swap tokens

# Screenshots/Videos
![image](https://user-images.githubusercontent.com/70885163/95192997-c2101c00-07db-11eb-9d07-c7efe590f203.png)
https://drive.google.com/file/d/14iyl9gRV7pmDig3QefY38eysV1Au99EI/view

# Environment
**Desktop:**
- OS: Win 10
- Browsers: Chrome, Brave, FF
- Version 10/6/2020 11.00 AM UTC

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in the Deploy tab and reproduce the flow by selecting Token A and Token B, applying the market price, then swapping the tokens. Trace the token-swap handling and verify that the Start Price field shows the intended cleared state after the swap.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.