gnosis / gnosis/safe-cmm-app-react

Feature: Strategies > Closed tab: Implement missing parts

Open
#175 0 comments 0 reactions 1 assignee Claimed by @alfetopito View on GitHub
Dominant language
TypeScript
Stars
2
Forks
1
PR merge metrics
No merged PRs in 30d

Description

# Description

Strategies > Closed tab: Implement missing parts

Current:
![screenshot_2020-11-27_10-20-21](https://user-images.githubusercontent.com/43217/100476305-10ce8980-309a-11eb-9061-d8fc3959cc42.png)

[Design](https://projects.invisionapp.com/d/main/default/#/console/20213446/427462306/preview):
![screenshot_2020-11-27_10-21-31](https://user-images.githubusercontent.com/43217/100476374-39ef1a00-309a-11eb-87e8-971e6af01b51.png)

# Requirements

- On rows:
- [x] Total value claimable
- [ ] (maybe?) claimable balances indicator
- On expanded view:
- [x] Strategy details
- [x] Trades
- [x] Deployed params
- [x] Final ROI (Not according to design)
- [x] Final APY (Not according to design)

**Note**: When implementing, use 1 PR per requirement

# Background

- Trades and deployed params can probably be reused without changes from Active tab.
- Final ROI and Final APY (APR) calculation is expensive and should be moved to inside the Strategy tab

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.