gnosis / gnosis/safe-cmm-app-react

Bug: UI issues with Deploy strategy form

Open
#116 3 comments 1 reaction 0 assignees View on GitHub
bug
Dominant language
TypeScript
Stars
2
Forks
1
PR merge metrics
No merged PRs in 30d

Description

# Description
**UI issues:**
1. Deploy strategy button: Button's text should be in bold
2. 'Total investment:' is displayed as 'Total funding:' on the [mock-up](https://projects.invisionapp.com/share/VXXWLEE7534#/screens/427462294) . May be, it would be nice to change it to correspond to the 'Funding' fields
3. Token A and Token B values should be in bold
4. Market price value should be in bold as well as 'per' in the market price explanation
![image](https://user-images.githubusercontent.com/70885163/95863447-dc627080-0d6c-11eb-8844-3df2559d77f7.png)

**Enhancement:** it would be nice to display a loader during the whole process: 'Deploy strategy' button -> Submit -> Confirm transaction in Metamask ->success

**Not yet implemented:**
1. Price in $ is not yet implemented #95
2. Price fork widget is still not implemented #94
3. Warning message before deploying an one token strategy/strategy with higher prices is not yet implemented #29
![image](https://user-images.githubusercontent.com/70885163/95862087-12065a00-0d6b-11eb-88dc-0efc3e11f73f.png)

# Environment
**Desktop:**
- OS: Win10
- Browser Chrome, FF, Brave
- Version 189412279 - 98816d8fae540d8fa2633bcbc0741dcadd62c4d0

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.