gnosis / gnosis/safe-cmm-app-react

Bug: UI issues with Pending strategies screen

Open
#111 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
TypeScript
Stars
2
Forks
1
PR merge metrics
No merged PRs in 30d

Description

# Description
Related to the #61
I assume that UI of the tab is not yet completely implemented, however, I would better post here my notes

# To Reproduce:
1. Open the [mock-up](https://projects.invisionapp.com/share/VXXWLEE7534#/screens/427462305) and the Strategies - Pending tab
2. Compare the screens

# Expected Behaviour
All the options/items/styles should be the same

# Actual Behaviour
1. Deploy/Strategies tabs' names are in upper-case (should not be)
2. Grid column names are not in bold, not in upper-case (should be)

3. Date format is incorrect (see the pic)
4. 'Nonce' column is not present on the mock-up (should be removed?)
5. Price range values look different as they are shown on the mock-up. From and To values should be displayed in separate lines
6. Brackets values look different as they are shown on the mock-up
7. Status is not orange-coloured
8. Strategy details are not in bold
9. Loader is shifted when a list of strategies is loaded

# Screenshots/Videos
![headers](https://user-images.githubusercontent.com/70885163/95740734-b9b15880-0c95-11eb-88ef-21b23d079812.jpg)
![UI](https://user-images.githubusercontent.com/70885163/95741009-2debfc00-0c96-11eb-96a4-27114af52792.jpg)

# Environment
**Desktop:**
- OS: Win 10
- Browser Chrome, FF. Brave
- Version 189412279 - 98816d8fae540d8fa2633bcbc0741dcadd62c4d0

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at the Strategies - Pending tab and compare it with the linked InVision mock-up, using the screenshots and the nine listed discrepancies as the checklist. Done means the labels, headers, date and value formatting, colors, emphasis, column set, and loader position match the mock-up across the reported browsers.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
32/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.