glslify / glslify/glsl-perturb-normal

Rename vViewPosition to vEyeDir

Open
#2 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
GLSL
Stars
36
Forks
3
PR merge metrics
No merged PRs in 30d

Description

In the source code you use `V` which is usually used for View Vector aka Eye Direction.
Even the vertex shader calculates eye direction.

```
// eyeDir = cameraPosInViewSpace - viewPos
// eyeDir = vec3(0.0, 0.0, 0.0) - viewPos
// eyeDir = -viewPos

vViewPosition = -viewPos.xyz
```

https://github.com/glslify/glsl-perturb-normal/blob/master/demo/vert.glsl#L10

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.