glotzerlab / glotzerlab/MatSpat

BIOINF 531 HW02 - Review

Open
#3 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Jupyter Notebook
Stars
0
Forks
0
PR merge metrics
No merged PRs in 30d

Description

Hey Ninad,

I think your project is off to an incredibly impressive start; the repository structure is a masterclass in modern Python development that I’m personally learning a lot from, especially your use of tox for multi-version testing, py.typed for type safety, and the clean modularity of your src/ sub-packages. There is a creative merge of two fields here, and looking at the design documents and the repo structure, it’s clear you have a strong vision for this tool. I have a few observations from a user perspective:

  • README Clarity: While your approach is innovative and explained in great detail in the SRS, adding some of those broader details to the README would help explain the tool's purpose to a general user. For example, a specific biological "use case" (like modeling the Tumor Microenvironment) would clarify the application for those without a physics background. Additionally, providing specific examples of expected input formats would help users get started more quickly.
  • Data Integrity (FR-1.4): Regarding the handling of missing values, I wonder if "masking" incomplete cells as "unknown" rather than dropping them might better preserve spatial density. I'm concerned that dropping rows entirely could lead to losing spatial context or affecting the connectivity metrics of neighboring cells.
  • Spatial Requirements: I was also wondering about the requirement for "points on a grid." Since biological cells are often irregularly spaced, will the tool still apply to images with sparse cell density? Are there strict requirements for the spatial distribution of the input data? Defining these constraints in the README would be very helpful.

Overall, I really appreciate your far-sightedness and the professional structure of this repo. Your choice of computational tools makes the project look very robust, and I’m looking forward to seeing the progress and how the tool expands!

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the README and the SRS, then inspect the source package structure and the handling described for FR-1.4. Determine whether the requested README additions and input constraints are defined well enough to document, and whether the missing-value and spatial-grid questions require a maintainer decision before work can be considered done.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data, documentation
Issue type
Documentation
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.