globalizejs / globalizejs/globalize

`"short"` date skeleton parses single-digit years

Open
#928 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
4.8k
Forks
585
PR merge metrics
No merged PRs in 30d

Description

Our code is exercising [this commit](https://github.com/rxaviers/globalize/commit/0083518995026152740575f85b4da1719295f48a) right now and it feels very, very strange that with the `"short"` date skeleton, we get these results:

- `"12/24/3"` parses ⁉️
- `"12/24/33"` parses
- `"12/24/333"` does not parse
- `"12/24/3333"` does not parse

I understand this change for days and months. And I'm sure there are obscure use cases (archaeologists?) for whom parsing a single-digit year makes sense. But my guess is the vast majority of cases where `globalize` parsing is being used for e.g. form input validation, this is unwanted and frankly confusing behavior.

I'm not sure I read [this thread](https://github.com/globalizejs/globalize/issues/695) correctly -- is there a way to disable the behavior where single-digit years now parse? Seems like this should be opt-in behavior for years, or at the very least an option to opt-out.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.