globalizejs / globalizejs/globalize

Build: check built files don't contain external dependencies

Open
#371 1 comment 0 reactions 0 assignees View on GitHub
help wanted
Dominant language
JavaScript
Stars
4.8k
Forks
585
PR merge metrics
No merged PRs in 30d

Description

We just dealt with failures in functional tests that turned out to be caused by `cldr/supplemental` being added as a dependecy in one place, but not properly included in the build in a different place (requirejs build configuration, `exclude` option).

To make it easier to spot this kind of issue, we should write a build task that looks at files built in `dist/` and throws an error if any file contains the Cldrjs library, or any other always-excluded dependency.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.