globalizejs / globalizejs/globalize
Code cleanup: Simplify tests util functions that passes assert as a parameter
Open
help wanted
quick change
- Dominant language
- JavaScript
- Stars
- 4.8k
- Forks
- 585
- PR merge metrics
- No merged PRs in 30d
Description
Ref: https://github.com/jquery/globalize/pull/351/files#r21450909
---
``` js
util.assertParameterPresence( assert, "currency", function() {
Globalize.currencyFormatter();
});
```
@jzaefferer
> I brought this up before, might be worth another try. Can this be changed to the below?
>
> ``` js
> assert.parameterPresence( "currency", ... );
> ```
>
> The same applies to any other calls that pass assert as a parameter
@rxaviers
> Sorry if I missed it. But, I don't remember such comment. If you say it's better overloading assert, it shall be. Will be tracked as a separate issue #359
Contributor guide
Assessment
This issue has not been assessed yet.