gliderlabs / gliderlabs/cmd

@comlab: improving errors

Open
#73 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
28
Forks
4
PR merge metrics
No merged PRs in 30d

Description

This is for comlab, but documented here for now while we work on Cmd. I think Comlab should be where we standardize error wrapping/enrichment, whether it's using github.com/pkg/errors or adding tracing or whatever.

This idea was inspired by a problem with using Comlab extensions in Cmd: Comlab provides a daemon component with lifecycle hooks, including start. Dynamodb uses this to ensure tables or returns an error. Since the error is logged by daemon, it's reported as an error from the daemon package, which is misleading/confusing:
```
12:14:08.725 [daemon] err=InvalidParameter: 1 validation error(s) found.
- minimum field size of 3, DescribeTableInput.TableName.
```
This would be a common problem as projects get larger. Our logger should be able to see if an error is being logged and get the package from there instead. So when Comlab provides error wrapping or whatever, it should include the package so logging can pick that up.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.