glideapps / glideapps/quicktype
request npm-package deprecated and tests wont run
- Dominant language
- TypeScript
- Stars
- 13.9k
- Forks
- 1.2k
- Avg merge
- 8h 53m
- Merged PRs (30d)
- 369
Description
As of Feb 11, 2020 the npm package `request` is deprecated.
Please check this [npm site](https://www.npmjs.com/package/request) and [github repo](https://github.com/request/request#deprecated).
This means, the tests cannot depend on this package. Test wont run in a freshly setup dev environment for developers.
Following is the error caused in Ubuntu 18 and node 12.16.1....
```
root@c195251b0e84:/quicktype# npm run test
> quicktype@15.0.0 test /quicktype
> jest && script/test
FAIL src/__tests__/cli/ci.test.ts
● Test suite failed to run
Cannot find module 'request'
at node_modules/request-promise-native/lib/rp.js:8:12
at module.exports (node_modules/stealthy-require/lib/index.js:62:23)
at Object. (node_modules/request-promise-native/lib/rp.js:7:15)
Test Suites: 1 failed, 1 total
Tests: 0 total
Snapshots: 0 total
Time: 0.097s
Ran all test suites.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! quicktype@15.0.0 test: `jest && script/test`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the quicktype@15.0.0 test script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR! /root/.npm/_logs/2020-03-09T21_51_00_393Z-debug.log
```
Contributor guide
Assessment
This issue has not been assessed yet.