glanceapp / glanceapp/glance

Hangs on startServer failures

Open
#950 0 comments 0 reactions 0 assignees View on GitHub
bug report
Dominant language
Go
Stars
37.1k
Forks
1.5k
Avg merge
1h 11m
Merged PRs (30d)
1

Description

### Description

`startServer` doesn't exit on failure, as seen [here](https://github.com/glanceapp/glance/blob/main/internal/glance/main.go#L142). I'm running Glance in a systemd service and can't tell that the server failed to start without an exit code.

Is there existing code that relies on this kind of behaviour? or can an exit call safely be made in the `startServer` function?

An example of a failure that I'd like to detect, is when the port is already in use: `Failed to start server: listen tcp 10.0.0.5:8581: bind: cannot assign requested address`

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.