giuseppec / giuseppec/iml

Feature - request inclusion of raw results as well as aggregated summaries in returned object

Open
#184 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
R
Stars
503
Forks
87
PR merge metrics
No merged PRs in 30d

Description

Please consider including the raw results as well as aggregated results in the value returned by methods such as `FeatureImp$new` - e.g. in lines 312 - 325 of `FeatureImp.R`:

``` r
result <- result[, list(
"importance" = median(importance_raw),
"permutation.error" = median(permutation_error),
"importance.05" = quantile(importance_raw, probs = 0.05),
"importance.95" = quantile(importance_raw, probs = 0.95)
), by = list(feature)]
result <- result[order(result$importance, decreasing = TRUE), ]
# Removes the n column
result <- result[, list(
feature, importance.05, importance, importance.95,
permutation.error
)]
private$finished <- TRUE
self$results <- data.frame(result)
```

It would be nice to add `importance_raw` as a list element either in results or at some higher level of the returned object. That way it allows us to make our own aggregations so we can change the cut off %s, plot the whole distribution, use a different summary statistic (e.g. I note another issue #170 is asking for mean instead of median). And similarly for other methods that return aggregated summaries from some raw initial result.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.