gitui-org / gitui-org/gitui

Feature: Theme option to make `cmdbar_bg` transparent

Open
#3,011 0 comments 0 reactions 0 assignees View on GitHub
feature-request
Dominant language
Rust
Stars
22.5k
Forks
773
PR merge metrics
No merged PRs in 30d

Description

When using a terminal with opacity/blur, it would be nice to disable the bg fill of the cmdbar items. Currently, it looks like this:

Image

And this is what I want:

Image

### Solution alternatives

IMO the idiomatic way to do this would be to allow `cmdbar_bg: None` in the theme config file, but since configs are applied via `struct_patch`, it would require turning the field into `Option` and `None` by default (if the default is `Some(Blue)`, patching `None` won't override it).

Another way would be creating a new config option like `disable_cmdbar_bg: bool` (default false).

I implemented the first one in a fork, but don't know if it's the preferred alternative. I'd be happy to make a PR :)

Contributor guide

Open the contributing guide

Research direction

The issue names `cmdbar_bg`, theme config files, and `struct_patch`; start by tracing where `cmdbar_bg` is defined and applied. Compare the proposed `Option` and boolean-option approaches, then verify that a theme can disable the fill while preserving the default appearance.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
cli
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
58/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.