gitui-org / gitui-org/gitui

Lots of memory usage with GBs sized files in diff

Open
#1,698 1 comment 3 reactions 0 assignees View on GitHub
bug dormant
Dominant language
Rust
Stars
22.5k
Forks
773
PR merge metrics
No merged PRs in 30d

Description

**Describe the bug**

Opening the app in a repo containing a large uncommitted file has gitui quickly consuming all available memory on my system. I have to quit quickly before my system halts.

**To Reproduce**

1. place a multi GB file in a repo
2. open `gitui`
3. scroll down and select this file
4. (optional) scroll away and select another file, notice that memory usage continues to climb

**Expected behaviour**

It took me a while to notice the issue, as it was taking down my machine before I could play-around, I was assuming it was another cause.

It appears that gitui was trying to present the diff of the new uncommitted file to me. I believe the flame graph below confirms that `git_diff_file_content__init_from_src()`.

Some potential solutions:

1. Perhaps have a limit on the size of file contents we're willing to present to the user in the diff viewer
2. or perhaps only present the file content on-focus of the diff viewer (on the right)

**Screenshots**
![Screenshot from 2023-05-23 08-39-05](https://github.com/extrawurst/gitui/assets/1245553/2d6c9366-fbb1-48c2-b92b-a9d49749d27f)

**Context (please complete the following information):**
- Fedora Linux 38.20230520.0 (Silverblue)
- gitui 0.20.1
- Rust version: 1.69.0

**Additional context**

`make profile` which produced the following flamegraph:

![flamegraph](https://github.com/extrawurst/gitui/assets/1245553/9446ff93-0187-433b-8c02-b3c67e151188)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.