gittuf / gittuf/github-app

Identify if `push` event is for a pull request merge without additional API calls

Open
#24 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
5
Forks
1
Avg merge
8h 41m
Merged PRs (30d)
8

Description

Currently, the push event handler creates an RSL entry for the reference in question. As GitHub sends a push event and a pull request event when a PR is merged, the push event handler uses the API to identify if the pushed commit is part of any pull requests that were merged. If so, an RSL entry is not created because the pull request handler takes care of it instead. This issue is to discuss if we can achieve this without the additional API call, especially since the API response may not indicate that the PR was merged (there may be a delay before the change in status is reflected in the API response).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.