gitpoint / gitpoint/git-point

Refactor and internationalize `IssueEventListItem`

Open
#795 6 comments 1 reaction 1 assignee Claimed by @machour View on GitHub
good for beginners help wanted
Dominant language
JavaScript
Stars
4.8k
Forks
771
PR merge metrics
No merged PRs in 30d

Description

This component could benefit from a refactoring similar to `EventsScreen`, where every event type would be handled by a dedicated method.

Instead of the big switch/case in render(), we could have something like this:

```
render() {
const { repository, event } = this.props;
const handler = camelCase(`handle_${event.event}`); // lodash's camelCase

if (typeof this[handler] === 'function') {
return this[handler](event, repository);
}

return null;
}
```

and implement `handleReviewRequested()`, `handleLabeled()`, etc.

We would then wrap strings with `utils.t()` to internationalize this component.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.