gitpoint / gitpoint/git-point

Modify directory structure

Open
#506 4 comments 3 reactions 0 assignees View on GitHub
discussion
Dominant language
JavaScript
Stars
4.8k
Forks
771
PR merge metrics
No merged PRs in 30d

Description

Our folder structure has changed as things have progressed and I'm thinking of another pattern we can start moving towards. I think having a folder structure for every component might be something we need to move towards. For example, our low level components in `components/`

```
- components/
- Button/
- button.component.js
- button.styled.js
// ...
```

And our container components (our "screens")

```
- screens/
- notifications/
- notifications.component.js
- notifications.styled.js
- notifications.container.js
- notifications.action.js
- notifications.reducer.js
- notifications.selector.js
- notifications.route.js
- notifications.type.js
- organization
// ...
```

With this pattern each of our components will be purely JSX renders that accept props. A container file like `notifications.container.js` will be something like the following:

```
import { compose } from 'recompose';
import { connect } from 'react-redux';
import { mapDispatchers } from 'utils';

import { Notification } from './notification.component';
import { notificationConnector } from './notification.selectors';

import { getUnreadNotifications } from './notification.actions';
import { getPendingNotifications } from './notification.actions';

const dispatchers = mapDispatchers({
getUnreadNotifications,
getPendingNotifications,
});

export const NotificationContainer = compose(
connect(notificationConnector, dispatchers),
)(Notification);
```

Keeping this logic separate from the actual component file means the actual notification component file does not represent any specific state logic. It just takes props, and the container is responsible for mapping those props to states and actions. In this example, also taking advantage of recompose. `mapDispatchers` can also be a utils method that leverages `bindActionCreators` from redux.

This is a pattern a lot of my colleagues here at work are using and I'm really starting to see the benefit. Will love to hear everyone's opinions 💬

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.