Leeway vet doesn't return a non-zero exit code on failures
Open
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 183
- Forks
- 27
- PR merge metrics
- No merged PRs in 30d
Description
Currently leeway vet doesn't return a non-zero exit code when it fails.
From a gitpod-io/gitpod workspace running 0.5.2-d3ff827:
$ leeway vet
ERRO[0008] components/ide/jetbrains/image: EOF
$ echo $?
0
Here's a screenshot of one of our builds where you see the same behaviour in Werft:
Keep in mind that this specific error will go away with this PR
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the failure with the leeway vet command and checking how its reported errors are converted into a process exit status. The fix is complete when a vet failure returns a non-zero status, while successful vet runs continue to return zero; add or update a regression test if the command's existing test coverage provides one.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- build-system, cli
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100