gitpod-io / gitpod-io/gitpod

GitLab commit tree URL parsing issue

Open
#8,174 4 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

feature: context awareness git provider: gitlab meta: never-stale team: webapp type: bug
Dominant language
TypeScript
Stars
13.8k
Forks
1.4k
Avg merge
17h 58m
Merged PRs (30d)
5

Description

Bug description

If you want to check the file structure of a commit, you are probably opening it with Gitpod in 2 different ways:

  1. From the commit page (GitHub example, GitLab example)
  2. From the file tree of the commit (GitHub example, GitLab example)

It looks like as opposed to the first option, if you try to open the second example with GitLab, you get an error, because Gitpod incorrectly parses the GitLab commit tree URL. This doesn't happen with GitHub nor opening from a GitLab commit page.

Steps to reproduce

Buckle up, a very involving reproduction incoming!

  1. Open a commit-specific file tree URL in Gitpod
  2. Observe the error

image

Expected behavior

I expect the URL to work because

  1. It is a pretty normal URL to open a workspace from
  2. There is Gitpod button present so it looks like it is open-able.
Example repository

No response

Anything else?

Thanks @krystofex for letting me know about the issue 🧡 .

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the linked GitLab commit-specific tree URL in Gitpod, then trace the GitLab URL-parsing entry point that handles commit pages and file trees. Confirm that the tree URL is parsed as the intended commit and that opening the linked URL no longer produces the reported error.

Written by the indexing model from the issue text.

Assessment

Tech stack
gitlab, typescript
Domain
devtools
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.