gitpod-io / gitpod-io/gitpod

[Security] Block certain gp commands when sharing a workspace

Open
#6,782 7 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

component: gp cli feature: collaboration meta: never-stale team: IDE
Dominant language
TypeScript
Stars
13.8k
Forks
1.4k
Avg merge
17h 58m
Merged PRs (30d)
5

Description

Is your feature request related to a problem? Please describe

Sharing a workspace, comes with a huge security flaw, because you also share your git credentials, and secrets stored in your user account.

Describe the behaviour you'd like

When a workspace is shared, the commands gp env (access to user variables) and gp credential-helper (access to git credentials) should be disabled.
That way sharing a workspace with others becomes safe! Users I share the workspace with, can make changes in that specific workspace (that's what I specifically allowed when clicking "Share Workspace"), but they don't have access to my permissions or secrets. They can no longer access my other repos or information that I don't want to share.

Describe alternatives you've considered

My poor man's hack that I use until this feature is officially implemented, a script that removes the credential.helper line from ~/.gitconfig https://github.com/shaal/DrupalPod/pull/46/files#diff-6ed300724c7e75fd4724d06dd9f6d386c13c69e35037f3807aea78811235bafaR6

Additional context

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the implementations of the gp env and gp credential-helper commands, then trace how workspace sharing is represented. Done means both commands are unavailable in a shared workspace while remaining available in an unshared workspace; the payload names no specific files or tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
cli, security
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.