Better feedback when copying URLs
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 13.8k
- Forks
- 1.4k
- Avg merge
- 17h 58m
- Merged PRs (30d)
- 5
Description
When on the integrations page in the settings, one can create a custom GitHub/GitLab self-hosted GitPod integration. When creating an integration, the user has to copy a redirect URL, which is triggered by pressing a button. That's alright, but I think we can have some sort of feedback when the copying was either successful or if there was a problem with it.
Approach
The icon in use is (AFAIK) duplicate from Heroicons. This leaves 2 options I can think of:
- After
onClick, the icon could be changed tocheckorx, depending on the result - The initial icon could be changed to
clipboardorclipboard-copyand after a successful copy toclipboard-check(what about if it fails though.)
The code is located here:
https://github.com/gitpod-io/gitpod/blob/6f15a4355420eddec28478b175311c843e4a1198/components/dashboard/src/settings/Integrations.tsx#L652
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in components/dashboard/src/settings/Integrations.tsx around line 652 and inspect the redirect-URL copy button and its onClick behavior. Determine how successful and failed copying should be represented, then verify that the UI gives distinct feedback for both outcomes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100