gitpod-io / gitpod-io/gitpod

Fix rounded corner / background gap in ContextMenu

Open
#5,086 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

component: dashboard feature: teams and projects [DEPRECATED] meta: never-stale team: webapp type: improvement
Dominant language
TypeScript
Stars
13.8k
Forks
1.4k
Avg merge
17h 58m
Merged PRs (30d)
5

Description

Bug description

There is a breeze coming through this gap, and it should be fixed, ideally before the winter. 🌬️ 🥶

From https://github.com/gitpod-io/gitpod/pull/5077#discussion_r684024685 :

issue: This is minor but there's a small gap on the corners due to corner radiuses. It should be barely noticable but if there's an easy fix let's also include it here. Otherwise, a follow up issue could suffice. 🏓

A B
Screenshot 2021-08-06 at 10 46 57 AM Screenshot 2021-08-06 at 10 46 43 AM
Steps to reproduce
  1. Click on any DropDown / ContextMenu in the dashboard
  2. Zoom in
  3. Feelsbadman
Expected behavior
  1. Feelsgoodman
Example repository

https://github.com/gitpod-io/gitpod

Anything else?

Do you have any fries? 🍟

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the gap in a dashboard DropDown or ContextMenu while zoomed in, then trace the ContextMenu implementation and its styling. The issue is done when the rounded corners no longer reveal a background gap and the behavior is checked on the affected menus.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.