gitpod PR check: The check finishes long before the prebuild is complete
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 13.8k
- Forks
- 1.4k
- Avg merge
- 17h 58m
- Merged PRs (30d)
- 5
Description
Bug description
If you have a project set up with
pullRequests: true
pullRequestsFromForks: true
addCheck: true
then a PR will include a check for gitpod prebuilding the workspace. And it works.
The problem here is that the check goes green long before the prebuild is complete, sometimes several minutes before.
Steps to reproduce
- Open a PR on https://github.com/rfay/test-gitpod-prebuild - just use the GitHub editor to make a small change to the README.
- Wait for the PR's gitpod check to go green
- Click the link on the check. You'll see it still prebuilding and far from done.
Expected behavior
The completion of the gitpod check should indicate that the prebuild is complete.
Example repository
https://github.com/rfay/test-gitpod-prebuild but it's just a playground to demonstrate this. Feel free to create PRs there
Anything else?
Thanks for a great project that gets better all the time.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the behavior with the pullRequests, pullRequestsFromForks, and addCheck settings in the linked test-gitpod-prebuild repository, then inspect the Gitpod PR check and prebuild status it links to. Done means the check stays pending until the prebuild completes and turns green only afterward.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- cloud, developer-experience
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100