gitpod-io / gitpod-io/gitpod

[supervisor] non blocking terminal reading

Open
#2,254 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

aspect: performance aspect: tech-debt component: supervisor feature: tasks meta: never-stale team: IDE type: feature request
Dominant language
TypeScript
Stars
13.8k
Forks
1.4k
Avg merge
17h 58m
Merged PRs (30d)
5

Description

Right now one client can block reading from a task terminal. Instead we could look into non blocking solutions.

In Theia, we don't directly write to each client but into the ring buffer from this each client then reads with own speed without blocking other clients.

@csweichel pointed out how go channels can be used as ring buffers: https://tanzu.vmware.com/content/blog/a-channel-based-ring-buffer-in-go

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the supervisor code that reads from task terminals; the issue names no files or tests. Review the described Theia ring-buffer approach and the linked Go channel-based ring-buffer article. Done means one client's terminal-reading behavior no longer blocks other clients, with the behavior verified by relevant tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, typescript
Domain
backend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.