gitpod-io / gitpod-io/gitpod

Update browser extension button style and order

Open
#2,110 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

component: browser-extension meta: never-stale
Dominant language
TypeScript
Stars
13.8k
Forks
1.4k
Avg merge
17h 58m
Merged PRs (30d)
5

Description

Thanks @corneliusludmann for making this change!

However, I think this slightly degrades the user experience for GL and GH products since this will a) introduce a flickering button on page load across multiple pages and b) remove the primary button for repository cloning, opening an issue, and more.

I understand the intent of this change but this will break common navigation patterns used by GL and GH users, contributors, and maintainers as well as indirectly hurt overall UX for Gitpod. 😭

GL GH
gl gh

Question: What do you think of the proposal in https://github.com/gitpod-io/browser-extension/issues/24 to a) use a secondary button and b) move the action before the primary action? This would help a) avoid all the UX issues mentioned above, b) smoothly integrate with GL and GH without affecting their existing product UX, and c) will follow similar patterns used by other related extensions. [1]

/cc @svenefftinge

Originally posted by @gtsiolis in https://github.com/gitpod-io/browser-extension/pull/26#issuecomment-702792882

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the browser extension button implementation and review the proposal in issue 24 alongside the GitLab and GitHub examples linked here. Done means the extension action uses the proposed secondary styling and ordering without introducing page-load flicker or replacing the hosts' primary navigation actions.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.