Missing focus indicators for dashboard
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 13.8k
- Forks
- 1.4k
- Avg merge
- 17h 58m
- Merged PRs (30d)
- 5
Description
Bug description
From https://www.a11yproject.com/posts/never-remove-css-outlines/:
Removing outlines in CSS creates issues for people navigating the web with a keyboard.
For many elements in the Dashboard, there is no way to tell it is focused without taking action on it. This is bad for folks who use the keyboard to move around.
This is an incomplete list of the components I have encountered with this behavior:
- https://github.com/gitpod-io/gitpod/blob/main/components/dashboard/src/components/SelectableCardSolid.tsx
- https://github.com/gitpod-io/gitpod/blob/main/components/dashboard/src/components/CheckBox.tsx
- https://github.com/gitpod-io/gitpod/blob/main/components/dashboard/src/components/Button.tsx, specifically type
danger.secondaryhas very low contrast, even more pronounced in dark mode.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with components/dashboard/src/components/Button.tsx, focusing on the danger.secondary type and its contrast in dark mode. Review the related SelectableCardSolid.tsx and CheckBox.tsx references for existing focus-indicator patterns. Done means dashboard elements have visible keyboard focus indicators and the danger.secondary styling has sufficient contrast, including in dark mode.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- accessibility, frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100