gitpod-io / gitpod-io/gitpod

False Positive When Linting Large Amount of Files

Open
#13,656 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

component: agent-smith meta: never-stale team: workspace type: bug
Dominant language
TypeScript
Stars
13.8k
Forks
1.4k
Avg merge
17h 58m
Merged PRs (30d)
5

Description

Bug description

When in a workspace and when using a linter on a large amount of files (in this case ~7000 files) it will get caught by agent-smith and the workspace will be stopped and user blocked. I recommend viewing the attached support ticket for further information.

Google Logs Entry.

Steps to reproduce
  1. Clone
  2. Spin up a new workspace using that repository.
  3. Using your linting tool have it lint all ~7000 files - you may need to use something like a for loop.

--

The following steps are untested (I didn't want to block my own account), but in theory this should reproduce the issue.

  1. Create a new workspace from https://github.com/tldr-pages/tldr
  2. Run npm test.
  3. Observe the workspace is stopped and your account is blocked.

Review this function.

Workspace affected

45554c37-bd17-4d8d-9a02-1a1ffce21a7e

Expected behavior

Given that this is not nefarious or malicious behavior I wouldn't expect to get my account blocked when linting files.

Example repository

https://github.com/tldr-pages/tldr

Anything else?

N/A

Front logo Front conversations

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked Google Logs entry and the agent-smith behavior described in the report. Review scripts/test.sh in the tldr-pages/tldr repository and run npm test only in a safe workspace; done means linting roughly 7,000 files no longer incorrectly stops the workspace or blocks the user.

Written by the indexing model from the issue text.

Assessment

Tech stack
google-cloud, typescript
Domain
cloud, security
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.