Investigate Emoji States on the Feedback Modal
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 13.8k
- Forks
- 1.4k
- Avg merge
- 17h 58m
- Merged PRs (30d)
- 5
Description
Bug description
When going to submit feedback from https://gitpod.io/workspaces the other day I noticed on the modal that pops up the emoji I had selected didn't show any indication that I had selected in. I clicked on the other emoji to see if anything would change to let me know which emoji I had selected, but it did not. They always stayed grey.
https://www.loom.com/share/6c32db02e1af49c1a615b336ef2ba4fd
Of note, I am using Safari Version 15.6 (17613.3.9.1.5).
Steps to reproduce
- Visit https://gitpod.io/workspaces
- In the upper right corner click on the Feedback link.
- In the modal that pops up hover over the emoji and observe that even when you stay hovered over one it doesn't stayed colored.
- Click on one of the emoji to select it, and observe on the next part of the modal the emoji you selected does not seem to be colored to indicate you had selected it.
- You should also observe that hovering over the emoji also seems to not work properly either in that they don't stay colored.
Workspace affected
No response
Expected behavior
I would expect that when I hover over an emoji and leave my cursor on it that the emoji stays colored. I would also expect that the emoji I selected on the first part of the modal be shown as selected in the second part of the modal.
Example repository
No response
Anything else?
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the feedback modal from the workspaces page, including the hover and selection steps in Safari. Trace the workspace feedback modal implementation and its existing tests, if present; done means hovered emojis show their colored state and the selected emoji remains visibly selected in the next modal step.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100