gitpod-io / gitpod-io/gitpod

Update error message copy when maximum number of users reached per license

Open
#11,791 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

aspect: authentication component: dashboard meta: never-stale team: webapp type: improvement
Dominant language
TypeScript
Stars
13.8k
Forks
1.4k
Avg merge
17h 58m
Merged PRs (30d)
5

Description

Problem to solve

Following up from https://github.com/gitpod-io/gitpod/pull/11768#discussion_r934903448, the current message shown when the maximum number of users reached per license has the following issues:

  1. It's using an error prefix unnecessarily.
  2. It's not clear whether the user actually sign up or not.

Error: Maximum number of users permitted by the license exceeded

CURRENT
Screenshot 2022-08-02 at 10 37 26 AM
Proposal

Update error message copy when maximum number of users reached per license, with a simpler copy but also better structure using bolder font weight for the first sentence.

Seems like the error is also coming from the backend, cross-posting in case this makes it more challenging to come up with the bolder sentence:

https://github.com/gitpod-io/gitpod/blob/ca802d2e7e8dae9b44425f3b65104654cb9fc41c/components/server/ee/src/user/user-service.ts#L90

For example:

Maximum number of users reached. We could not sign you in because this instance has reached the maximum number of allowed users.

See also relevant discussion (internal). Cc @lucasvaltl @geropl @AlexTugarev

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with components/server/ee/src/user/user-service.ts around line 90 and read the linked discussion for the current error wording. Trace where that message is presented to users so the first sentence can use bolder text. Done means the unnecessary error prefix is removed and the message clearly explains that sign-in could not proceed because the license user limit was reached.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
backend
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.